expression: fix case-sensitive problem for function INSTR and LOCATE (#16792) #17068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
component/expression
type/4.0-cherry-pick
type/bugfix
ghost
removed their request for review
|
/rebuild |
bb7133
added
status/LGT2
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #16792 to release-4.0
What problem does this PR solve?
Fix some bugs found in the internal collation test.
Though MySQL document says
This function is multibyte safe, and is case-sensitive only if at least one argument is a binary string., it's no true.For example, if one argument is utf8_bin and the other is utf8mb4_general_ci, these functions will be case-insensitive.
What is changed and how it works?
Use the collation we derive from the expression's arguments to decide if the function is case-sensitive.
Related changes
Check List
Tests
Side effects
Release note