-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv: fix transaction too large error message #17198
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #17198 +/- ##
===========================================
Coverage 79.9887% 79.9887%
===========================================
Files 511 511
Lines 139202 139202
===========================================
Hits 111346 111346
Misses 18889 18889
Partials 8967 8967 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just use the transaction limit instead of sandbox.Size()
when returning the error?
Pushed a new commit, just change the error message. PTAL @jackysp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@bobotu merge failed. |
/merge |
/run-all-tests |
@bobotu merge failed. |
/merge |
/run-all-tests |
@bobotu merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@bobotu merge failed. |
/merge |
/run-all-tests |
@bobotu merge failed. |
/rebuild |
/merge |
/run-all-tests |
@bobotu merge failed. |
/merge |
/run-all-tests |
cherry pick to release-4.0 in PR #17219 |
What problem does this PR solve?
The size hint in
TxnTooLarge
's message is the size limit of the staging buffer.It is hard to understand.
What is changed and how it works?
Use the
TxnTotalSizeLimit
to generate error message.Release note
Transaction is too large
easier to understand.