Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: fix a panic when creating key partition table (#16260) #17242

Merged
merged 3 commits into from
May 20, 2020
Merged

ddl: fix a panic when creating key partition table (#16260) #17242

merged 3 commits into from
May 20, 2020

Conversation

tiancaiamao
Copy link
Contributor

Cherry pick #16260

mysql> create table t(a char(5), unique key(a(5))) partition by key() partitions 5;
ERROR 2013 (HY000): Lost connection to MySQL server during query

Release note

  • Fix panic when creating a key partition table

@tiancaiamao
ddl: fix a panic when creating key partition table (pingcap#16260)
f62c34a 
mysql> create table t(a char(5), unique key(a(5))) partition by key() partitions 5;
ERROR 2013 (HY000): Lost connection to MySQL server during query
@tiancaiamao tiancaiamao added type/4.0-cherry-pick type/bugfix This PR fixes a bug. sig/sql-infra SIG: SQL Infra labels May 15, 2020
@tiancaiamao tiancaiamao added this to the v4.0.0-ga milestone May 15, 2020
@tiancaiamao
Copy link
Contributor Author

PTAL @wjhuang2016 @jackysp

jackysp
jackysp reviewed May 16, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wjhuang2016
wjhuang2016 reviewed May 16, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao
Copy link
Contributor Author

Fix #17323

@jebter
Copy link

jebter commented May 20, 2020

/approve

sre-bot
sre-bot approved these changes May 20, 2020
View reviewed changes
Copy link
Contributor

@sre-bot sre-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 20, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 20, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 20, 2020

/run-all-tests

@sre-bot sre-bot merged commit ff187d2 into pingcap:release-4.0 May 20, 2020
@wjhuang2016 wjhuang2016 mentioned this pull request May 22, 2020
Closed
@tiancaiamao tiancaiamao deleted the cherry-16260 branch May 26, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@jackysp jackysp jackysp left review comments

@sre-bot sre-bot sre-bot approved these changes

Assignees
No one assigned
Labels
sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.0-ga
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @jebter @sre-bot @jackysp @wjhuang2016