-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression,executor: fix DIV() as partition expression behavior under ERROR_FOR_DIVISION_BY_ZERO sql_mode #17302
Conversation
… ERROR_FOR_DIVISION_BY_ZERO sql_mode
PTAL @XuHuaiyu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
Signed-off-by: sre-bot <sre-bot@pingcap.com>
cherry pick to release-4.0 in PR #17314 |
What problem does this PR solve?
Problem Summary:
Currently, the function expression "enclosure" the session context, causing the
creating time context differ from using time context.
If the sql mode change, the behavior is incorrect.
What is changed and how it works?
What's Changed:
Implement
evalIntWithCtx
method for IntDIVInt function signature.How it Works:
Use the correct session context.
Related changes
Check List
Tests
Release note