-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix wrong agg function when agg push down union (#17022) #17328
Merged
sre-bot
merged 3 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-b248783dfe5b
May 21, 2020
Merged
planner: fix wrong agg function when agg push down union (#17022) #17328
sre-bot
merged 3 commits into
pingcap:release-4.0
from
sre-bot:release-4.0-b248783dfe5b
May 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
sre-bot
added
sig/execution
SIG execution
sig/planner
SIG: Planner
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
type/4.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
May 20, 2020
ghost
requested review from
SunRunAway and
lzmhhh123
and removed request for
a team
May 20, 2020 13:54
XuHuaiyu
reviewed
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
approved these changes
May 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
1 similar comment
/run-all-tests |
@jebter can merge |
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
May 21, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/release-blocker
This issue blocks a release. Please solve it ASAP.
sig/execution
SIG execution
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
type/4.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17022 to release-4.0
What problem does this PR solve?
Issue Number: close #16861
Problem Summary: when the aggregation is pushed down the union, we should append the first row for group by items.
What is changed and how it works?
What's Changed: append the first row when the partial aggregation is built under the union.
Related changes
Check List
Tests
Side effects
Release note
Fix the panic when aggregation push down enable on the partition table.