Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: check required order property for enforced stream aggregation (#17338) #17346

Merged
merged 1 commit into from
May 25, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 21, 2020

cherry-pick #17338 to release-3.1


What problem does this PR solve?

Issue Number: close #17325

Problem Summary:

Wrong result for enforced stream aggregation when order is required.

What is changed and how it works?

What's Changed:

Check if the enforced stream aggregation can satisfy the required order property.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

N/A

Release note

  • Fix wrong result order for enforced stream aggregation.

@sre-bot
Copy link
Contributor Author

sre-bot commented May 21, 2020

/run-all-tests

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@eurekaka eurekaka force-pushed the release-3.1-134e691d6f5f branch from 5a20356 to 2cdbd22 Compare May 22, 2020 02:53
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels May 25, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 25, 2020

/run-all-tests

@sre-bot sre-bot merged commit a22d3e7 into pingcap:release-3.1 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants