meta: fix the allocator batch size compute logic (#17271) #17548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/sql-infra
|
/run-all-tests |
|
/run-mybatis-test |
1 similar comment
|
/run-mybatis-test |
djshow832
reviewed
Jun 1, 2020
|
conflict files |
tangenta
approved these changes
Jun 1, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17271 to release-3.0
What problem does this PR solve?
Problem Summary: fix logic in allocator batch size computation
What is changed and how it works?
What's Changed:
when the local cache size if not enough for allocN, do the new batchSize computation based on the global new base in the txn.
so we postpone the NextStep adjustment to meta txn and store it after that.
Related changes
Check List
Tests
Release note