-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: remove sensitive information in slow-log ... (#18107) #18128
executor: remove sensitive information in slow-log ... (#18107) #18128
Conversation
/run-all-tests |
/run-all-tests |
LGTM, but you need to amend f34b470 to remove the author "cs" to fix CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@qw4990,Thanks for you review. |
/run-all-tests |
/rebuild |
1 similar comment
/rebuild |
…gcap#18107) Signed-off-by: crazycs520 <crazycs520@gmail.com>
af568e1
to
9eb4eeb
Compare
/run-all-tests |
/rebuild |
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
Signed-off-by: crazycs520 <crazycs520@gmail.com>
/run-all-tests |
@qw4990, Thanks for your review, however we are sorry that your vote won't be count. You already give a LGTM to this PR |
cherry-pick #18107 to release-3.0
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
Before this PR, TiDB slow log will record sensitive information such as passwords in slow-log query.
This PR remove sensitive information in slow-log. Such as below:
execute below sql:
The related slow-log will be:
the related statement will be:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
Check List
Tests
Side effects
Release note