-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: return the actual error when conn panic (#18494) #18498
Merged
ti-srebot
merged 1 commit into
pingcap:release-3.0
from
ti-srebot:release-3.0-165bdfdec842
Jul 13, 2020
Merged
server: return the actual error when conn panic (#18494) #18498
ti-srebot
merged 1 commit into
pingcap:release-3.0
from
ti-srebot:release-3.0-165bdfdec842
Jul 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
ti-srebot
added
component/server
type/3.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Jul 13, 2020
lysu
reviewed
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lysu,Thanks for your review. |
SunRunAway
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ti-srebot
added
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Jul 13, 2020
@SunRunAway,Thanks for your review. |
/merge |
ti-srebot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jul 13, 2020
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/server
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #18494 to release-3.0
What problem does this PR solve?
Issue Number: close #18112
Problem Summary:
TiDB does not return the actual error when recovering a goroutine.
What is changed and how it works?
What's Changed:
How it Works:
As the title says.
Related changes
Check List
Tests
As the description in the related issue.
We'll get
ERROR 1105 (HY000): Out Of Memory Quota![conn_id=1]
after this commit.Side effects
N/A
Release note