expression: support handle two collation cannot substituted to each other #19036
Conversation
xiongjiwei
changed the title
xiongjiwei
force-pushed
the
collation-mix
branch
from
a791c48
to
285ee6e
Compare
Codecov Report
@@ Coverage Diff @@
## master #19036 +/- ##
================================================
+ Coverage 79.3672% 79.3870% +0.0197%
================================================
Files 546 546
Lines 148996 148033 -963
================================================
- Hits 118254 117519 -735
+ Misses 21249 21018 -231
- Partials 9493 9496 +3 |
|
@xiongjiwei Sorry for my late reply. Could you please add some tests for this? |
@qw4990 It's ok. no new tests for this PR, this PR does not change logic, it is same as original logic, and this PR will be used in future. you can see the conversation with djshow832 to find why I file this PR. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@xiongjiwei merge failed. |
|
/merge |
|
@wjhuang2016 Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIGs: execution(slack). |
|
/label needs-cherry-pick-4.0 |
|
/run-cherry-pick |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #22582 |
What problem does this PR solve?
current collation strictness cannot handle situation if two collation cannot substituted to each other
e.g.
a != bin collationA,a=bin collationBandc=din collationA,c!=din collationBWhat is changed and how it works?
group collation by strictness, two collation can be substituted each other if they are in same group.
store strictnessship in a map with group id, collation group id in value is stricter than collation group id in key
Release note
CollationStrictnessto support incompatible strictnessship