expression: Support stddev_pop function #19195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
reviewed
Aug 14, 2020
executor/aggfuncs/func_stddevpop.go
Outdated
| // return variance | ||
| //} | ||
|
|
||
| func (e *stdDevPop4Float64) UpdatePartialResult(sctx sessionctx.Context, rowsInGroup []chunk.Row, pr PartialResult) (memDelta int64, err error) { |
There was a problem hiding this comment.
You do not need to implement this function, just let stdDevPop4Float64 inherit from varPop4Float64, and override the AppendFinalResult2Chunk method.
6 tasks
ghost
reviewed
Aug 15, 2020
SunRunAway
reviewed
Aug 18, 2020
SunRunAway
changed the title
ichn-hu
requested changes
Aug 25, 2020
executor/aggfuncs/func_stddevpop.go
Outdated
| chk.AppendNull(e.ordinal) | ||
| return nil | ||
| } | ||
| varicance := p.variance / float64(p.count) |
executor/aggfuncs/func_stddevpop.go
Outdated
| chk.AppendNull(e.ordinal) | ||
| return nil | ||
| } | ||
| varicance := p.variance / float64(p.count) |
|
LGTM |
ti-srebot
approved these changes
Aug 27, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #19540 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Aug 27, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #19541 |
ti-srebot
added a commit
that referenced
this pull request
Sep 1, 2020
zz-jason
pushed a commit
that referenced
this pull request
Sep 2, 2020
9 tasks
This was referenced Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Part of #7623
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note