-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix build table reader for index join on partition table #19210
executor: fix build table reader for index join on partition table #19210
Conversation
PTAL @lzmhhh123 @lysu @imtbkcat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does IndexReader
have the same problem?
Codecov Report
@@ Coverage Diff @@
## master #19210 +/- ##
================================================
- Coverage 79.0998% 79.0774% -0.0224%
================================================
Files 549 549
Lines 149678 149236 -442
================================================
- Hits 118395 118012 -383
+ Misses 21761 21690 -71
- Partials 9522 9534 +12 |
IndexReader have already handled the partition table as join inner table case. But not all the cases are covered until now. As I've said on another PR #18862
I'll handle the remain cases later, after I solve this bug #19089 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
/merge |
/run-all-tests |
@tiancaiamao merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@tiancaiamao merge failed. |
/run-integration-copr-test |
What problem does this PR solve?
Issue Number: close #19145
Problem Summary:
In
IndexLookUpMergeJoin
, the inner join table reader executor is built at runtime.The inner table may be a partition table, but the old logic
dataReaderBuilder.buildTableReaderForIndexJoin
does not handle that.What is changed and how it works?
What's Changed:
How it Works:
buildTableReaderForIndexJoin
This fix works on the master branch, 4.0 is fixed by #19151
Check List
Tests
Release note