executor: avoid goroutine leak in index Lookup join #19251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test. BTW, please also create an issue for this PR. |
SunRunAway
reviewed
Aug 28, 2020
fzhedu
force-pushed
the
IndexLoopupJoinBug
branch
from
f389d45 to
5ca6c4d
Compare
SunRunAway
reviewed
Sep 3, 2020
|
/run-check_dev_2 |
fzhedu
force-pushed
the
IndexLoopupJoinBug
branch
from
52b72c5 to
2b1a325
Compare
fzhedu
force-pushed
the
IndexLoopupJoinBug
branch
from
2b1a325 to
515ba52
Compare
|
/run-check_dev_2 |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 3, 2020
|
/reward 300 |
|
This PR's linked issue is not picked. |
|
/reward 300 |
|
Reward success. |
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@fzhedu, Congratulations, you get 300 in this PR, and your total score is 300 in high-performance challenge program. DetailsTip : None Warning: cc: Mentor @SunRunAway |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.0 in PR #20791 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #20792 |
ti-srebot
added a commit
that referenced
this pull request
Nov 3, 2020
Closed
ti-srebot
added a commit
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #19354
Problem Summary: the index lookup join leak goroutines if inner works build innerExec failed, because it returns immediately after opened, ignore closing.
besides, if one innerworker find
ctx.Done(), it returns but lettask.innerResultis null, which is later called but without judgement. This causes panic.What is changed and how it works?
Proposal: xxx
What's Changed:
move
defer innerExec.closebefore return errors.judgen
task.innerResultbefore using it.How it Works:
Related changes
Check List
Tests
Side effects
Release note