Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix invalid convert type in between...and... #19820

Merged
merged 23 commits into from
Dec 4, 2020

Conversation

xiongjiwei
Copy link
Contributor

@xiongjiwei xiongjiwei commented Sep 6, 2020

What problem does this PR solve?

Issue Number: close #11177

Problem Summary:

What is changed and how it works?

  • get correct type for all type conversion in between ... and ...

Tests

  • Unit test

Release note

  • fix an issue that invalid results using BETWEEN...AND... with type conversion

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Sep 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Sep 6, 2020

@xiongjiwei
Copy link
Contributor Author

/rebuild

@xiongjiwei xiongjiwei changed the title fix convert type in between and planner: fix invalid convert type in between...and... Sep 6, 2020
@xiongjiwei xiongjiwei marked this pull request as ready for review September 7, 2020 00:23
@xiongjiwei xiongjiwei requested review from a team as code owners September 7, 2020 00:23
@xiongjiwei xiongjiwei requested review from SunRunAway and removed request for a team September 7, 2020 00:23
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 7, 2020
@lzmhhh123
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 10, 2020
ti-srebot
ti-srebot previously approved these changes Oct 10, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 10, 2020
@SunRunAway
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 10, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot added the status/LGT3 The PR has already had 3 LGTM. label Dec 4, 2020
@XuHuaiyu
Copy link
Contributor

XuHuaiyu commented Dec 4, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21409

@ti-srebot
Copy link
Contributor

/run-all-tests

@wjhuang2016
Copy link
Member

/run-unit-test

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@wjhuang2016
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 21456

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@xiongjiwei merge failed.

@wjhuang2016
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 1df8107 into pingcap:master Dec 4, 2020
@ti-challenge-bot
Copy link

@xiongjiwei, Congratulations, you get 300 in this PR, and your total score is 300 in high-performance challenge program.

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #21503

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 4, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #21504

asiafrank pushed a commit to asiafrank/tidb that referenced this pull request Dec 8, 2020
ti-srebot added a commit that referenced this pull request Jan 26, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@xiongjiwei xiongjiwei added the type/bugfix This PR fixes a bug. label Oct 13, 2021
@xiongjiwei xiongjiwei deleted the bug-11177 branch September 23, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid results using BETWEEN...AND... with type conversion