Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: Support distinct in select stddev_pop() (#19680) #19919

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #19680 to release-3.0


What problem does this PR solve?

Issue Number: close #19676

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
mysql> create table t(id int);
Query OK, 0 rows affected (0.00 sec)

mysql> insert into t values(1),(2);
Query OK, 2 rows affected (0.00 sec)
Records: 2  Duplicates: 0  Warnings: 0

mysql> select stddev_pop(id) from t;
+----------------+
| stddev_pop(id) |
+----------------+
|            0.5 |
+----------------+
1 row in set (0.00 sec)

mysql> insert into t values(1);
Query OK, 1 row affected (0.00 sec)

mysql> select stddev_pop(distinct id) from t;
+-------------------------+
| stddev_pop(distinct id) |
+-------------------------+
|                     0.5 |
+-------------------------+
1 row in set (0.00 sec)

Side effects

Release note

  • No release note.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 10, 2020
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 11, 2020
@wshwsh12
Copy link
Contributor

/run-all-tests

1 similar comment
@Win-Man
Copy link
Contributor

Win-Man commented Sep 11, 2020

/run-all-tests

@lilinghai
Copy link
Contributor

/build

@lilinghai
Copy link
Contributor

/run-all-tests

@SunRunAway SunRunAway merged commit d23d8bd into pingcap:release-3.0 Sep 11, 2020
@SunRunAway SunRunAway deleted the release-3.0-71d726206756 branch September 11, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/3.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants