Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/design: add pinyin order collation for utf8mb4 charset #19984

Merged
merged 18 commits into from
Nov 6, 2020
Merged

doc/design: add pinyin order collation for utf8mb4 charset #19984

merged 18 commits into from
Nov 6, 2020

Conversation

xiongjiwei
Copy link
Contributor

What problem does this PR solve?

Issue Number: #19747

Release note

  • add proposal for pinyin order

@ti-srebot ti-srebot added the contribution This PR is from a community contributor. label Sep 14, 2020
@bb7133
Copy link
Member

bb7133 commented Sep 15, 2020

/run-all-tests

bb7133
bb7133 reviewed Sep 19, 2020
View reviewed changes
docs/design/2020-09-12-utf8mb4_zh_0900_as_cs.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4_zh_0900_as_cs.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4_zh_0900_as_cs.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4_zh_0900_as_cs.md Outdated Show resolved Hide resolved
@xiongjiwei xiongjiwei mentioned this pull request Oct 19, 2020
Merged
@xiongjiwei xiongjiwei mentioned this pull request Oct 22, 2020
Merged
This was referenced Nov 4, 2020
Closed
Closed
@bb7133
Copy link
Member

bb7133 commented Nov 5, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2020
@bb7133
Copy link
Member

bb7133 commented Nov 5, 2020

PTAL @wjhuang2016

wjhuang2016
wjhuang2016 reviewed Nov 6, 2020
View reviewed changes
docs/design/2020-09-12-utf8mb4-pinyin-order.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4-pinyin-order.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4-pinyin-order.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4-pinyin-order.md Outdated Show resolved Hide resolved
docs/design/2020-09-12-utf8mb4-pinyin-order.md Outdated Show resolved Hide resolved
wjhuang2016
wjhuang2016 approved these changes Nov 6, 2020
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 6, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 6, 2020
@wjhuang2016
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 6, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 155e908 into pingcap:master Nov 6, 2020
@xiongjiwei xiongjiwei deleted the zh_cs_as branch November 6, 2020 06:08
@xiongjiwei xiongjiwei mentioned this pull request Sep 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 left review comments

@bb7133 bb7133 bb7133 left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xiongjiwei @bb7133 @wjhuang2016 @ti-srebot @lance6716