Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix query slow_query error when slow-log file not exist #20000

Merged
merged 5 commits into from
Sep 15, 2020

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Sep 15, 2020

Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Close #19985

> select count(*) from information_schema.cluster_slow_query;
(1105, 'other error: open tidb-slow.log: no such file or directory')

What is changed and how it works?

Ignore file not exist error when slow-log file error.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • Fix issue query slow_query error when slow-log file not exist

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 added the type/bugfix This PR fixes a bug. label Sep 15, 2020
@crazycs520 crazycs520 requested a review from a team as a code owner September 15, 2020 06:58
@crazycs520 crazycs520 requested review from wshwsh12 and removed request for a team September 15, 2020 06:58
@github-actions github-actions bot added the sig/execution SIG execution label Sep 15, 2020
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 15, 2020
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 15, 2020
@AilinKid
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-unit-test

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-unit-test

@crazycs520
Copy link
Contributor Author

/run-unit-test

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-unit-test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-unit-test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-unit-test

@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 merged commit aed24e4 into pingcap:master Sep 15, 2020
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 in PR #20050

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20051

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Sep 17, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 in PR #20052

crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 17, 2020
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 28, 2020
crazycs520 added a commit to ti-srebot/tidb that referenced this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After scaling out tidb-server, execute SQL ERROR 1105 (HY000)
4 participants