-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: avoid constPropgate for the hybrid types (#20258) #20296
expression: avoid constPropgate for the hybrid types (#20258) #20296
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve conflicts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lzmhhh123, Thanks for your review, however we are sorry that your vote won't be count. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
Sorry @bb7133, this branch cannot be merged without an approval of release maintainers |
/run-all-tests |
LGTM |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/run-unit-test |
cherry-pick #20258 to release-3.0
What problem does this PR solve?
Issue Number: close #20180
Problem Summary:
In condition
t.a=t1.c
, the EvalType is ETString.In condition
t.b=t1.c
, the EvalType type is ETInt.So that it shouldn't use propagate column optimization, only if the propConstSolver can distinguish them.
In the case above, it will construct a new condition
t.a=t.b
and push down to tablet
, and make the join result wrong.What is changed and how it works?
Proposal: xxx
What's Changed: avoid propagate column EQ for Hybrid type (enum,set,bit).
How it Works:
Related changes
Check List
Tests
Side effects
Release note