Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: force print slow log when trace is enabled #20569

Merged
merged 1 commit into from
Oct 22, 2020
Merged

executor: force print slow log when trace is enabled #20569

merged 1 commit into from
Oct 22, 2020

Conversation

bobotu
Copy link
Contributor

@bobotu bobotu commented Oct 21, 2020

What is changed and how it works?

Print slow log for every query when runtime/trace is enabled. This can help profiling.

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note.

@bobotu bobotu added type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-4.0 labels Oct 21, 2020
@bobotu bobotu requested review from lysu and jackysp October 21, 2020 11:32
@bobotu bobotu requested a review from a team as a code owner October 21, 2020 11:32
@bobotu bobotu requested review from XuHuaiyu and removed request for a team October 21, 2020 11:32
@github-actions github-actions bot added the sig/execution SIG execution label Oct 21, 2020
lysu
lysu reviewed Oct 21, 2020
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2020
@lysu
Copy link
Contributor

lysu commented Oct 21, 2020

maybe we need some way to notice this to the user - -?

jackysp
jackysp approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Oct 21, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Oct 21, 2020
@jackysp
Copy link
Member

jackysp commented Oct 21, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 21, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@bobotu merge failed.

@bobotu
Copy link
Contributor Author

bobotu commented Oct 22, 2020

/merge

@ti-srebot
Copy link
Contributor

@bobotu Oops! auto merge is restricted to Committers of the SIG.See the corresponding SIG page for more information. Related SIG: execution(slack).

@bobotu bobotu removed the sig/execution SIG execution label Oct 22, 2020
@bobotu
Copy link
Contributor Author

bobotu commented Oct 22, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@github-actions github-actions bot added the sig/execution SIG execution label Oct 22, 2020
@ti-srebot ti-srebot merged commit e302200 into pingcap:master Oct 22, 2020
@bobotu bobotu deleted the force-slow-log branch October 22, 2020 03:03
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 22, 2020
@ti-srebot
cherry pick pingcap#20569 to release-4.0
9fd4984 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 22, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #20578

ti-srebot added a commit that referenced this pull request Nov 4, 2020
@ti-srebot
executor: force print slow log when trace is enabled (#20569) (#20578)
821b753 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@jackysp jackysp jackysp approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bobotu @lysu @jackysp @ti-srebot