expression: fix ADD_DATE daylight saving time change (#20871) #20888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/expression
sig/execution
lzmhhh123
reviewed
Nov 6, 2020
expression/builtin_time.go
Outdated
Comment on lines
2855
to
2856
| func (du *baseDateArithmitical) addDate(ctx sessionctx.Context, date types.Time, year, month, day, nano int64) (types.Time, bool, error) { | ||
| goTime, err := date.GoTime(time.UTC) |
There was a problem hiding this comment.
It seems that's not the correct change.
There was a problem hiding this comment.
Okay, I see, I'll fix them.
|
@qw4990 PTAL |
ti-srebot
added
status/LGT2
|
/run-all-tests |
This was referenced Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #20871 to release-4.0
What problem does this PR solve?
Issue Number: close #19667
Problem Summary: golang's time api considers daylight saving time for time arithematics, but time in UTC won't be affected.
What is changed and how it works?
Proposal: xxx
What's Changed: change use of time.Locale to time.UTC.
Related changes
Check List
Tests
Side effects
N/A
Release note