executor, planner: fix some cases for natural_using_join #20977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
added
type/bugfix
XuHuaiyu
requested review from
qw4990,
SunRunAway,
winoros and
lzmhhh123
and removed request for
a team and
SunRunAway
XuHuaiyu
changed the title
Closed
|
/reward 900 |
|
Reward success. |
lzmhhh123
reviewed
Nov 11, 2020
winoros
reviewed
Nov 12, 2020
| field.SetText(name.ColName.O) | ||
| resultList = append(resultList, field) | ||
| list := unfoldWildStar(field, p.OutputNames(), p.Schema().Columns) | ||
| if isJoin && join.redundantSchema != nil && field.WildCard.Table.L != "" { |
| @@ -978,6 +980,19 @@ func (b *PlanBuilder) buildProjectionField(ctx context.Context, p LogicalPlan, f | |||
| return newCol, name, nil | |||
| } | |||
|
|
|||
| func findColFromNaturalUsingJoin(p LogicalPlan, col *expression.Column) (name *types.FieldName) { | |||
There was a problem hiding this comment.
Add comment for the function header.
| if idx < 0 { | ||
| return -1, nil | ||
| switch x := p.(type) { |
There was a problem hiding this comment.
Add comment for this switch clause
winoros
reviewed
Nov 12, 2020
| // We record the full `rightPlan.Schema` as `redundantSchema` in order to | ||
| // record the redundant column in `rightPlan` and the output columns order | ||
| // of the `rightPlan`. | ||
| // For SQL like `select t1.*, t2.* from t1 left join t2 using(a)`, we can |
There was a problem hiding this comment.
three-way join will be a better example.
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 12, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@XuHuaiyu merge failed. |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Nov 12, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #21021 |
ti-srebot
added a commit
that referenced
this pull request
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
close #20477
close #20441
close #15844
close #20958
close #20476
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Support querying the coalesced columns in natural_using_join.
How it Works:
Related changes
Check List
Tests
Side effects
/AN
Release note