util: fix wrong calculation to get memory usage. (#21158) #21160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
|
@wshwsh12 you're already a collaborator in bot's repo. |
ti-srebot
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21158 to release-3.0
What problem does this PR solve?
Issue Number: close #xxx
Problem Summary:
On MacOs, the calculation ignore inactive memory. It will make memory-alarm trigger unexpected.
What is changed and how it works?
Proposal: xxx
What's Changed:
Use
mem.Useddirectly.On MacOs, it should consider inactive memory.
On Linux, I read the source code.
ret.Used = ret.Total - ret.Free - ret.Buffers - ret.Cached. So the result is same with old.How it Works:
Related changes
Need cherry-pick to 3.0,4.0
Check List
Tests
Side effects
Release note