Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add metric for connection idle time (#21265) #21301

Merged
merged 4 commits into from
Nov 26, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #21265 to release-4.0


What problem does this PR solve?

Add a client connection idle time duration metric. such as below:

image

Then, it will be easy to check the idle connections.

The idle time is calculated from the last finish execution time.

What is changed and how it works?

add metric.

Related changes

  • Need to cherry-pick to the release branch: release 4.0

Check List

Tests

  • Manual test

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM

Release note

  • Add metric for connection idle time

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@crazycs520 you're already a collaborator in bot's repo.

Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
Copy link
Contributor

@jackysp @lysu PTAL

@crazycs520 crazycs520 removed the sig/sql-infra SIG: SQL Infra label Nov 26, 2020
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Nov 26, 2020
@lysu
Copy link
Contributor

lysu commented Nov 26, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2020
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 26, 2020
@jackysp
Copy link
Member

jackysp commented Nov 26, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented Nov 26, 2020

Visit the grafana server at: http://172.16.5.5:31372, it will last for 5 hours

@jackysp
Copy link
Member

jackysp commented Nov 26, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 26, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 20837

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit bba4f48 into pingcap:release-4.0 Nov 26, 2020
@crazycs520 crazycs520 deleted the release-4.0-727d8f195c97 branch November 26, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants