executor: Fix pessimistic lock doesn't work on the partition table for subquery/joins #21641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @crazycs520 @tiancaiamao |
blacktear23
commented
Dec 10, 2020
executor/executor.go
Outdated
| return errors.Trace(errors.Errorf("Cannot get schema info for table %s", tblInfo.Name.O)) | ||
| } | ||
| colNamePrefix := fmt.Sprintf("%s.%s.", dbInfo.Name.L, tblInfo.Name.L) | ||
| cols := pt.Cols() |
There was a problem hiding this comment.
Do we need to use VisibleCols instead of Cols? @bb7133
Closed
|
/run-all-tests |
|
What's the status of this PR? @blacktear23 |
|
@youjiali1995 Still active, waiting for review. |
|
@bb7133 @lzmhhh123 PTAL |
|
Fix #20028 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21618, close #21509
Problem Summary:
In
SelectLockExec.Nextthe second parameter forGetPartitionByRowfunction is not contains only partitioned table's columns data, it is all selected table's result. So it will return wrong partition table ID.What is changed and how it works?
What's Changed:
Add a projection step to filter row data to partitioned table related Datum array, then call
GetPartitionByRowfunction.Related changes
Check List
Tests
Side effects
Release note