executor: fix insert ignore into not exists partition (#21904)
#21971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
ti-srebot
added
sig/execution
|
@lysu you're already a collaborator in bot's repo. |
|
Please fix CI. |
|
/run-all-tests |
ti-srebot
added
status/LGT2
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: lysu <sulifx@gmail.com>
lysu
force-pushed
the
release-4.0-0735a0c92422
branch
from
49b5fcd
to
9c1d1e9
Compare
|
@zz-jason conflict resolved, please help merge if free thx |
qw4990
approved these changes
Jan 26, 2021
ti-srebot
added
status/LGT3
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #21904 to release-4.0
Signed-off-by: lysu sulifx@gmail.com
What problem does this PR solve?
Issue Number: close #21894
Problem Summary:
just as issue said, insert ignore to a non-exists should not report error
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#ignore-effect-on-execution
What is changed and how it works?
What's Changed, How it Works:
ignore rows that cannot found partition and continue insert remain rows
Related changes
Check List
Tests
Side effects
Release note
insert ignoreinto not exists partition should not report error