Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: handle duration type infer in least and greatest (#22271) #22580

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 27, 2021

cherry-pick #22271 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/22421

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/22421:release-4.0-4658536793d5

What problem does this PR solve?

Issue Number: close #22200

Problem Summary:

What is changed and how it works?

This pull request compares duration as string while they are formalized which will prevent panicking while encountering a non-handled duration type infer.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • expression: handle duration type infer in least and greatest

…#22271)

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
@qw4990 qw4990 added this to the v4.0.11 milestone Jan 27, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Jan 27, 2021

/run-all-tests

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 27, 2021
@time-and-fate
Copy link
Member

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 27, 2021
@ti-srebot ti-srebot added status/LGT3 The PR has already had 3 LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jan 27, 2021
@qw4990 qw4990 merged commit fbaf60c into pingcap:release-4.0 Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT3 The PR has already had 3 LGTM. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants