Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: deprecate alter-primary-key configuration #23270

Merged
merged 30 commits into from
Mar 18, 2021
Merged

*: deprecate alter-primary-key configuration #23270

merged 30 commits into from
Mar 18, 2021

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

This PR removes the config alter-primary-key. To alter the primary key, the users should use the NONCLUSTERED syntax instead to create a table.

What is changed and how it works?

What's Changed: Omitted.

How it Works: Omitted.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn!

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Breaking backward compatibility

Release note

  • The configuration alter-primary-key is deprecated. Use NONCLUSTERED instead.

@tangenta tangenta requested a review from a team as a code owner March 11, 2021 13:47
@tangenta tangenta requested review from wshwsh12 and removed request for a team March 11, 2021 13:47
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 11, 2021
@tangenta tangenta requested review from coocood, wjhuang2016 and lysu and removed request for wshwsh12 March 11, 2021 13:48
@tangenta tangenta mentioned this pull request Mar 11, 2021
Merged
@tangenta
Copy link
Contributor Author

Blocked by pingcap/br#853.

jackysp
jackysp reviewed Mar 15, 2021
View reviewed changes
ddl/ddl_api.go Outdated Show resolved Hide resolved
@tangenta
Copy link
Contributor Author

/rebuild

@tangenta tangenta requested a review from a team as a code owner March 16, 2021 04:13
@tangenta tangenta requested review from eurekaka and removed request for a team March 16, 2021 04:13
@tangenta
Copy link
Contributor Author

/rebuild

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 18, 2021
@lysu
Copy link
Contributor

lysu commented Mar 18, 2021

LGTM for 42e53ae

@ti-chi-bot
Copy link
Member

@lysu: Please use /LGTM instead of LGTM when you want to approve the pull request by comment.
If you use the GitHub review feature, please approve the PR directly, the comment will not take effect in the GitHub review feature.
If you have any qustions please refer to lgtm command help or lgtm plugin design.

If you have approved this PR, please ignore this reply. This reply is being used as a temporary reply during the migration of the new bot and will be removed on April 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0ad5e3d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 18, 2021
@ti-chi-bot ti-chi-bot merged commit 411dba2 into pingcap:master Mar 18, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Mar 18, 2021
@ti-srebot
cherry pick pingcap#23270 to release-5.0
ba7ebc2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #23394

This was referenced Mar 18, 2021
Closed
Closed
ti-chi-bot pushed a commit that referenced this pull request Mar 18, 2021
@ti-srebot
*: deprecate alter-primary-key configuration (#23270) (#23394)
c822691
@tangenta tangenta mentioned this pull request Mar 18, 2021
Merged
11 tasks
@ti-srebot ti-srebot mentioned this pull request Mar 18, 2021
Merged
@amyangfei amyangfei mentioned this pull request Mar 18, 2021
Merged
@marsishandsome marsishandsome mentioned this pull request Mar 19, 2021
Merged
@GMHDBJD GMHDBJD mentioned this pull request Mar 19, 2021
Closed
3 tasks
@tangenta tangenta mentioned this pull request Mar 19, 2021
Merged
@ti-srebot ti-srebot mentioned this pull request Mar 19, 2021
Merged
This was referenced Mar 20, 2021
Merged
Merged
@ti-srebot ti-srebot mentioned this pull request Mar 23, 2021
Merged
11 tasks
SabaPing pushed a commit to SabaPing/tidb that referenced this pull request Mar 25, 2021
@tangenta @SabaPing
*: deprecate alter-primary-key configuration (pingcap#23270)
02f9fc2
tisonkun
tisonkun reviewed Feb 28, 2022
View reviewed changes
ddl/serial_test.go
Comment on lines +56 to +57
// TODO(tangenta): Move all the parallel tests out of this file.
var _ = Suite(&testIntegrationSuite9{&testIntegrationSuite{}})
Copy link
Contributor

@tisonkun tisonkun Feb 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangenta shall we resolve this TODO now? I think it's in the way of #26022 and we'd really need to split all these huge test files under ddl package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysu lysu lysu left review comments

@jackysp jackysp jackysp left review comments

@tisonkun tisonkun tisonkun left review comments

@coocood coocood Awaiting requested review from coocood

@wjhuang2016 wjhuang2016 Awaiting requested review from wjhuang2016

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
component/config component/expression component/statistics needs-cherry-pick-release-5.0 sig/execution SIG execution sig/sql-infra SIG: SQL Infra size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tangenta @lysu @coocood @ti-chi-bot @ti-srebot @jackysp @tisonkun