expresssion: determine the field type of control function with enum type #24830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
added
the
size/S
Closed
XuHuaiyu
reviewed
May 24, 2021
expression/builtin_control.go
Outdated
| @@ -135,10 +135,16 @@ func InferType4ControlFuncs(lexp, rexp Expression) *types.FieldType { | |||
| resultEvalType := resultFieldType.EvalType() | |||
| if resultEvalType == types.ETInt { | |||
| resultFieldType.Decimal = 0 | |||
| if resultFieldType.Tp == mysql.TypeEnum { | |||
|
/lgtm |
lzmhhh123
approved these changes
May 27, 2021
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 54a440c
|
ti-chi-bot
added
the
status/can-merge
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
May 27, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #24915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #24543
Problem Summary:
What is changed and how it works?
Proposal: xxx
What's Changed:
Determine the field type of control function with enum type. If the return fieldtype is enum, we can use the evaltype to determine the fieldtype.
How it Works:
Related changes
Check List
Tests
Side effects
Release note