Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metric: fix wrong total-query-counter label #25402

Merged
merged 9 commits into from
Jun 15, 2021
Merged

metric: fix wrong total-query-counter label #25402

merged 9 commits into from
Jun 15, 2021

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Jun 15, 2021 •
edited
Loading

What problem does this PR solve?

Problem Summary:

there are two label ERROR and Error for total query counter which make user confused

image

What is changed and how it works?

Proposal: xxx

What's Changed, How it Works:

make them use Error instead of ERROR

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • No code

Side effects

  • n/a

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 15, 2021
@lysu lysu requested review from breezewish and crazycs520 June 15, 2021 03:07
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 15, 2021
xhebox
xhebox reviewed Jun 15, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It indeed fixed the problem. But I wonder why don't we just use metrics.LblOK and metrics.LblError? Will that break something?

Not a change request. Will give LGTM anyway after the response.

@breezewish
Copy link
Member

breezewish commented Jun 15, 2021 •
edited
Loading

Seems that in other places where this metrics is used, hard coded string is also used. So I'm fine with the current implementation. It's not making things worse :) However it will be definitely great if these are changed.

@ti-chi-bot
Copy link
Member

@breeswish: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@breezewish breezewish added the sig/diagnosis SIG: Diagnosis label Jun 15, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 15, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 15, 2021
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c46f7f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 15, 2021
@ti-chi-bot ti-chi-bot merged commit 0e3737b into pingcap:master Jun 15, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@lysu @ti-srebot
cherry pick pingcap#25402 to release-4.0
c4deb92 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #25444

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@lysu @ti-srebot
cherry pick pingcap#25402 to release-5.0
ca47c00 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25445

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Jun 15, 2021
@lysu @ti-srebot
cherry pick pingcap#25402 to release-5.1
588e966 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Jun 15, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #25446

ti-chi-bot pushed a commit that referenced this pull request Jun 16, 2021
@ti-srebot
metric: fix wrong total-query-counter label (#25402) (#25446)
87b7e13
ti-chi-bot pushed a commit that referenced this pull request Jul 7, 2021
@ti-srebot
metric: fix wrong total-query-counter label (#25402) (#25444)
56a7235
ti-chi-bot pushed a commit that referenced this pull request Aug 13, 2021
@ti-srebot
metric: fix wrong total-query-counter label (#25402) (#25445)
d79ef68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@breezewish breezewish breezewish approved these changes

@crazycs520 crazycs520 Awaiting requested review from crazycs520

Assignees
No one assigned
Labels
component/metrics needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 sig/diagnosis SIG: Diagnosis sig/sql-infra SIG: SQL Infra size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysu @breezewish @ti-chi-bot @ti-srebot @xhebox