-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner,executor: fix point get for update read panic on partition table (#25537) #25552
planner,executor: fix point get for update read panic on partition table (#25537) #25552
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@tiancaiamao you're already a collaborator in bot's repo. |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@zhouqiang-cl please help give a label thx~ |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8950532
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #25537 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/25552
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #25528
Problem Summary:
#21148 add an extra partition ID column for the select lock executor, the table reader can handle it, but I forget the point / batch point get executor.
What is changed and how it works?
What's Changed:
Do not convert to point get executor for that case.
I see #21148 is already cherry picked to 5.1 and it introduce this bug, so it's better to fix the bug quickly.
This fix is simplest.
How it Works:
Avoid generate point get executor for that case.
Related changes
Check List
Tests
Side effects
Release note
Fix a bug which is caused by prior bug fix PR