-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix wrong plan caused by shallow copy schema columns #27798
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/sig planner |
/run-check_dev_2 |
/run-sqllogic-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please also add the test case in #26554 and close it.
... And we need cherry-pick this pr to 4.0, 5.0, 5.1, 5.2
/label needs-cherry-pick- |
@time-and-fate: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/label needs-cherry-pick-4.0 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 918cb53
|
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-4.0 in PR #27836 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.0 in PR #27837 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.1 in PR #27838 |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
cherry pick to release-5.2 in PR #27839 |
What problem does this PR solve?
Issue Number: close #27797 close #26554
Problem Summary:
In agg push down, we make the schema of the Union and the first child of the Union(a DataSource in the case) share the same array.
Then in the column pruning, when we are pruning columns of the child of the Union, the schema of Union is also changed because they share the same slice.
What is changed and how it works?
Deep copy schema columns when push agg across Union.
Check List
Tests
Side effects
Documentation
Release note