Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: limit valid decimal length #28466

Merged
merged 2 commits into from
Oct 8, 2021
Merged

expression: limit valid decimal length #28466

merged 2 commits into from
Oct 8, 2021

Conversation

fzhedu
Copy link
Contributor

@fzhedu fzhedu commented Sep 28, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: close pingcap/tiflash#3091

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lzmhhh123
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2021
@fzhedu fzhedu added type/bugfix This PR fixes a bug. component/expression and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Sep 28, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@fzhedu fzhedu changed the title limit the max length of str expression: limit the max length of str Sep 29, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 29, 2021
@fzhedu fzhedu changed the title expression: limit the max length of str expression: limit the max length of str to valid decimal length Sep 29, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2021
windtalker
windtalker approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@windtalker: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@fzhedu fzhedu changed the title expression: limit the max length of str to valid decimal length expression: limit valid decimal length Sep 29, 2021
@fzhedu
Copy link
Contributor Author

fzhedu commented Sep 29, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2021
@lzmhhh123
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e579ec3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 8, 2021
@ti-chi-bot ti-chi-bot merged commit a18e05d into pingcap:master Oct 8, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 8, 2021
@fzhedu @ti-srebot
cherry pick pingcap#28466 to release-5.0
59469d9 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #28647

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 8, 2021
@fzhedu @ti-srebot
cherry pick pingcap#28466 to release-5.1
98ec00a 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.1 in PR #28648

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Oct 8, 2021
@fzhedu @ti-srebot
cherry pick pingcap#28466 to release-5.2
e3e233b 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Oct 8, 2021
Merged
12 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #28649

ti-chi-bot pushed a commit that referenced this pull request Oct 12, 2021
@ti-srebot
expression: limit valid decimal length (#28466) (#28648)
6be3ac5
ti-chi-bot pushed a commit that referenced this pull request Oct 12, 2021
@ti-srebot
expression: limit valid decimal length (#28466) (#28647)
90ae7cc
ti-chi-bot pushed a commit that referenced this pull request Oct 14, 2021
@ti-srebot
expression: limit valid decimal length (#28466) (#28649)
ecdd725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 approved these changes

@wjhuang2016 wjhuang2016 wjhuang2016 approved these changes

@windtalker windtalker windtalker approved these changes

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 needs-cherry-pick-release-5.1 needs-cherry-pick-release-5.2 release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DB::Exception: Wrong precision:128
7 participants
@fzhedu @ti-chi-bot @sre-bot @lzmhhh123 @ti-srebot @windtalker @wjhuang2016