server: migrate test-infra to testify for tidb_test.go #29535
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
yedamao
changed the title
ti-chi-bot
removed
the
do-not-merge/work-in-progress
|
@tisonkun Please take a look. |
| @@ -30,12 +31,16 @@ import ( | |||
| func TestMain(m *testing.M) { | |||
| testbridge.WorkaroundGoCheckFlags() | |||
|
|
|||
| runInGoTest = true // flag for NewServer to known it is running in test environment | |||
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 09f7ff4
|
ti-chi-bot
added
the
status/can-merge
|
/run-check_dev_2 |
|
@yedamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
| @@ -32,102 +32,48 @@ import ( | |||
| "os" | |||
| "path/filepath" | |||
There was a problem hiding this comment.
tidb_test contains build flags.
//go:build !race
// +build !race
it need to add to tidb_serial_test.go
| rows := tk.MustQuery(query, args...) | ||
| tk.require.True(rows.Next()) | ||
| tk.require.NoError(rows.Err()) | ||
| rows.Close() |
There was a problem hiding this comment.
You should check the error returned here I think. @yedamao could you submit a follow up to fix it?
What problem does this PR solve?
Issue Number: close #27806 #27805
Release note