Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: disable parallel to avoid data race when test #29739

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Nov 12, 2021

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Problem Summary:

statistics: disable parallel to avoid data race when test.

many tests will change domain.RunAutoAnalyze that lead to a data race.

Check List

Tests

  • Unit test

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 12, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lcwangchao
  • wjhuang2016

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 12, 2021
@hawkingrei hawkingrei changed the title statistics: disable parallel to avoid data race when test *: disable parallel to avoid data race when test Nov 12, 2021
@hawkingrei
Copy link
Member Author

/run-check_dev_2

@hawkingrei
Copy link
Member Author

@tisonkun @AilinKid @zimulala PTAL

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you indicate in the description where data race occurs?

@hawkingrei
Copy link
Member Author

Could you indicate in the description where data race occurs?

Yes, I have added.

Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to follow the practice in #26022

When test cases should be run in serial at the top level, move them into xxx_serial_test.go file.

otherwise, it decreases the readability of code.

@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2021
@hawkingrei hawkingrei force-pushed the disable_parallel branch 3 times, most recently from 1e70ef4 to 044ed2e Compare November 15, 2021 05:54
@hawkingrei
Copy link
Member Author

Please try to follow the practice in #26022

When test cases should be run in serial at the top level, move them into xxx_serial_test.go file.

otherwise, it decreases the readability of code.

I have fixed.

@hawkingrei hawkingrei force-pushed the disable_parallel branch 4 times, most recently from 193326e to 60ea6ae Compare November 15, 2021 06:41
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

@tisonkun @Defined2014 PTAL

@ti-chi-bot
Copy link
Member

@Defined2014: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 15, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 15, 2021
@wjhuang2016
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 36b9f72

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 15, 2021
@ti-chi-bot
Copy link
Member

@hawkingrei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 61c2a98 into pingcap:master Nov 15, 2021
@hawkingrei hawkingrei deleted the disable_parallel branch November 16, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants