Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix wrong flen when cast decimal to string (#29687) #30015

Merged
merged 5 commits into from
Apr 12, 2022
Merged

expression: fix wrong flen when cast decimal to string (#29687) #30015

merged 5 commits into from
Apr 12, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Nov 22, 2021 •
edited by guo-shaoge
Loading

cherry-pick #29687 to release-5.2
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/30015

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/30015:release-5.2-fef05d77d28e

Signed-off-by: guo-shaoge shaoge1994@163.com

What problem does this PR solve?

Issue Number: close #29417

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

expression: Fix the issue that length information is wrong when converting Decimal to String

@guo-shaoge @ti-srebot
cherry pick pingcap#29687 to release-5.2
0a3e276 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • wshwsh12

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 22, 2021
@ti-srebot ti-srebot mentioned this pull request Nov 22, 2021
Merged
12 tasks
@ti-srebot ti-srebot added component/expression size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/5.2-cherry-pick type/bugfix This PR fixes a bug. labels Nov 22, 2021
@ti-srebot ti-srebot added this to the v5.2.2 milestone Nov 22, 2021
@ti-srebot
Copy link
Contributor Author

@guo-shaoge you're already a collaborator in bot's repo.

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2021
@guo-shaoge
fix conflict
970ae44 
Signed-off-by: guo-shaoge <shaoge1994@163.com>
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 30, 2021
XuHuaiyu
XuHuaiyu approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 30, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 17, 2021
@VelocityLight VelocityLight added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 11, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Apr 12, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a24dacb0dbcb1e6e8af3d3961e237dd892199d43

@guo-shaoge
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 24d9d49

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 12, 2022
@ti-chi-bot ti-chi-bot merged commit 8a6e5a7 into pingcap:release-5.2 Apr 12, 2022
@zhouqiang-cl zhouqiang-cl modified the milestones: v5.2.2, v5.2.4 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@wshwsh12 wshwsh12 wshwsh12 approved these changes

Assignees

@guo-shaoge guo-shaoge

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/5.2-cherry-pick
Projects
None yet
Milestone
v5.2.4
Development

Successfully merging this pull request may close these issues.
8 participants
@ti-srebot @ti-chi-bot @sre-bot @guo-shaoge @XuHuaiyu @wshwsh12 @VelocityLight @zhouqiang-cl