planner: fix create binding panic when status.record-db-qp enable (#29519) #30372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #29519 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/30372
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #29503
Problem Summary:
nil
forast.SelectStmt.From
. When we create the empty table query, it will cause panic. E.g,select 1
.tableInfo
anddbInfo
toast.StmtNode
when we create the binding and the config record-db-qps enable.nil
ingetStmtDbLabel
function for*ast.CreateBindingStmt
, it will cause panic when the table is empty.What is changed and how it works?
nil
forast.SelectStmt.From
.tableInfo
anddbInfo
toast.StmtNode
when we create the binding and the config record-db-qps enable.nil
ingetStmtDbLabel
function for*ast.CreateBindingStmt
.Check List
Tests
Side effects
Documentation
Release note