Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: change parallel tests to serial tests #30432

Closed
wants to merge 3 commits into from
Closed

server: change parallel tests to serial tests #30432

wants to merge 3 commits into from

Conversation

djshow832
Copy link
Contributor

What problem does this PR solve?

Problem Summary:
There are many unstable tests in the server package recently, and we suspect it may be caused by parallel running.
I'm trying to change the parallel tests to serial tests. If it works, I'll move them from xxx_test.go to xxx_serial_test.go.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • sylzd

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2021
@djshow832
Copy link
Contributor Author

/run-check_dev_2

3 similar comments
@djshow832
Copy link
Contributor Author

/run-check_dev_2

@djshow832
Copy link
Contributor Author

/run-check_dev_2

@djshow832
Copy link
Contributor Author

/run-check_dev_2

bb7133
bb7133 reviewed Dec 6, 2021
View reviewed changes
server/http_handler_test.go Outdated
@@ -72,7 +72,6 @@ func createBasicHTTPHandlerTestSuite() *basicHTTPHandlerTestSuite {
}

func TestRegionIndexRange(t *testing.T) {
t.Parallel()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get the point why the t.Parallel() should be removed: according to #29374, the case was included by HTTPHandlerTestSuite which is not a SerialTestSuite.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that I need to change only the cases which run serially before the testing, instead of all parallel tests in these 2 files?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the thing: TestAllHistory also fails(#30256), but it ran in parallel all the time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that I need to change only the cases which run serially before the testing, instead of all parallel tests in these 2 files?

Theoretically, yes. However, it does not harm if we run all of them in serial, as long as the total time of it is acceptable, I want to confirm it with you firstly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted those tests and let's take some trials.

@bb7133
Copy link
Member

bb7133 commented Dec 6, 2021

/run-check_dev_2

@djshow832 djshow832 force-pushed the remove_server_parallel branch from b3bb036 to b8aa9ec Compare December 6, 2021 13:11
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 6, 2021
bb7133
bb7133 approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2021
sylzd
sylzd approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@sylzd sylzd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 7, 2021
@bb7133
Copy link
Member

bb7133 commented Dec 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b8aa9ec

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 7, 2021
@ti-chi-bot
Copy link
Member

@djshow832: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2021
@djshow832
Copy link
Contributor Author

This is solved by another PR, so I'll close it.

@djshow832 djshow832 closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bb7133 bb7133 bb7133 approved these changes

@sylzd sylzd sylzd approved these changes

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djshow832 @ti-chi-bot @bb7133 @hawkingrei @sylzd