Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix data race in builtin_other_vec_generated_test.go #30503

Merged
merged 2 commits into from
Dec 8, 2021
Merged

expression: fix data race in builtin_other_vec_generated_test.go #30503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a35e56
expression: fix data race in the builtin_other_vec_generated_test.go
hawkingrei Dec 7, 2021
67934ab
Merge branch 'master' into fix_data_race_in_vecExprBenchCases
ti-chi-bot Dec 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions expression/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1118,8 +1118,6 @@ func genVecExprBenchCase(ctx sessionctx.Context, funcName string, testCase vecEx
// testVectorizedEvalOneVec is used to verify that the vectorized
// expression is evaluated correctly during projection
func testVectorizedEvalOneVec(t *testing.T, vecExprCases vecExprBenchCases) {
t.Parallel()

ctx := mock.NewContext()
for funcName, testCases := range vecExprCases {
for _, testCase := range testCases {
Expand Down Expand Up @@ -1321,8 +1319,6 @@ func removeTestOptions(args []string) []string {
// testVectorizedBuiltinFunc is used to verify that the vectorized
// expression is evaluated correctly
func testVectorizedBuiltinFunc(t *testing.T, vecExprCases vecExprBenchCases) {
t.Parallel()

testFunc := make(map[string]bool)
argList := removeTestOptions(flag.Args())
testAll := len(argList) == 0
Expand Down