Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: regard NULL as point when accessing composite index (#30244) #30614

Merged

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Dec 10, 2021

cherry-pick #30244 #29999 #30340, no conflict


What problem does this PR solve?

Issue Number: close #29650

Problem Summary: planner: regard NULL as point when accessing composite index

What is changed and how it works?

planner: regard NULL as point when accessing composite index

Check List

Tests

  • Unit test

Release note

planner: regard NULL as point when accessing composite index

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 10, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Reminiscent
  • Yisaer

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qw4990 qw4990 requested a review from a team as a code owner December 10, 2021 06:34
@ti-chi-bot
Copy link
Member

@qw4990: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2021
@qw4990 qw4990 added sig/planner SIG: Planner and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2021
@qw4990 qw4990 requested review from Reminiscent and Yisaer December 10, 2021 06:35
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 10, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 10, 2021
@qw4990
Copy link
Contributor Author

qw4990 commented Dec 10, 2021

/run-all-tests

@zhouqiang-cl zhouqiang-cl merged commit 6605146 into pingcap:release-5.3-20211210 Dec 10, 2021
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants