-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression, planner: skip isNullRejected
check when contain outer not after PushDownNot
#31210
Conversation
… after PushDownNot
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/28d4ae096b598cab686f83a07d26adae08577eb3 |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/merge |
This pull request has been accepted and is ready to merge. Commit hash: aeea3ad
|
@rebelice: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #20510
Problem Summary:
The first step to check
isNullRejected
is to executePushDownNot
. And the correctness ofisNullRejected
depends onPushDownNot
. But we currently cannot handle complex situations inPushDownNot
correctly. eg. "not(0+(t1.a = 1 and t2.a = 2))". So at this time,isNullRejected
will get the wrong result.What is changed and how it works?
After
PushDownNot
, we check if there is outernot
. If yes, we skipisNullRejected
and return false.Check List
Tests
Side effects
Documentation
Release note