Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global_config: update pd version and client go version #31219

Merged
merged 95 commits into from
Feb 8, 2022
Merged

global_config: update pd version and client go version #31219

merged 95 commits into from
Feb 8, 2022

Conversation

LemonHX
Copy link
Contributor

@LemonHX LemonHX commented Dec 31, 2021

to adopt global config

Signed-off-by: lemonhx lemonhx@lemonhx.tech

What problem does this PR solve?

Issue Number: close #31218

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@LemonHX
update pd version and client go version
8565015 
to adopt global config

close: pingcap#31218
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 31, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • crazycs520
  • tangenta

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 31, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@LemonHX
Merge branch 'master' of https://github.com/pingcap/tidb into update_…
aed397f 
…pdclient_version

Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@LemonHX
implement mock pd for global config
f04523c 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
crazycs520
crazycs520 reviewed Dec 31, 2021
View reviewed changes
go.mod Outdated
@@ -103,3 +103,5 @@ replace github.com/pingcap/tidb/parser => ./parser

// fix potential security issue(CVE-2020-26160) introduced by indirect dependency.
replace github.com/dgrijalva/jwt-go => github.com/form3tech-oss/jwt-go v3.2.6-0.20210809144907-32ab6a8243d7+incompatible

replace github.com/tikv/client-go/v2 v2.0.0-rc.0.20211229051614-62d6b4a2e8f7 => github.com/lemonhx/client-go/v2 v2.0.0-rc.0.20211231054516-ed0388e01e9f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this after client-go merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for sure

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 31, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Dec 31, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@peng1999 peng1999 mentioned this pull request Dec 31, 2021
Merged
4 tasks
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 31, 2021
@LemonHX
fix lint
da04e19 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@LemonHX
Merge branch 'master' of https://github.com/pingcap/tidb into update_…
0243e66 
…pdclient_version

Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/2ee7b134e50999a2e48bda952c4b3996cbac6d40

@LemonHX
update version
cf3d6fc 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@LemonHX
update client go
73f7d78 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 5, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@andylokandy
Copy link
Contributor

@LemonHX Can we merge this PR? Cause' we are waiting for the kvproto update.

@LemonHX
update client go version
8de368e 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@sre-bot
Copy link
Contributor

sre-bot commented Jan 7, 2022

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@LemonHX
marged client go
45fc37a 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2022
@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

/run-unit-test

@LemonHX
fix make lightning
f9bc237 
Signed-off-by: lemonhx <lemonhx@lemonhx.tech>
@crazycs520
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f9bc237

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 7, 2022
@crazycs520
Copy link
Contributor

/merge

@crazycs520
Copy link
Contributor

/merge

1 similar comment
@crazycs520
Copy link
Contributor

/merge

@crazycs520
Copy link
Contributor

/merge

@crazycs520
Copy link
Contributor

/merge

1 similar comment
@crazycs520
Copy link
Contributor

/merge

@crazycs520
Copy link
Contributor

/merge

@crazycs520 crazycs520 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2022
@crazycs520
Copy link
Contributor

/merge

@hawkingrei
Copy link
Member

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 294a094 into pingcap:master Feb 8, 2022
@peng1999 peng1999 mentioned this pull request Feb 8, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkingrei hawkingrei hawkingrei left review comments

@tangenta tangenta tangenta approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update pd client version to adopt global config
10 participants
@LemonHX @ti-chi-bot @sre-bot @andylokandy @crazycs520 @disksing @hawkingrei @Mini256 @MyonKeminta @tangenta