Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: add retriver for tikv_region_peers (#30657) #32132

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Feb 7, 2022

cherry-pick #30657 to release-5.4
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/32132

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/32132:release-5.4-43b818b80d38

ref: #28330

What problem does this PR solve?

Issue Number: close #31050
Problem Summary:
The optimization idea is to add TikvRegionPeersExtractor to push down STORE_ID and REGION_ID and add tikvRegionPeersRetriever to fetch regions information from PD.

What is changed and how it works?

Time cost comparison:

# select count(*) from information_schema.tikv_region_peers;
+----------+
| count(*) |
+----------+
|   700476 |
+----------+
new: 1 row in set (10.30 sec)
old: 1 row in set (10.29 sec)
# almost cost the same time when fetch all regionsInfo

# select * from tikv_region_peers where region_id=395005;
+-----------+---------+----------+------------+-----------+--------+--------------+
| REGION_ID | PEER_ID | STORE_ID | IS_LEARNER | IS_LEADER | STATUS | DOWN_SECONDS |
+-----------+---------+----------+------------+-----------+--------+--------------+
|    395005 |  410054 |        4 |          0 |         1 | NORMAL |         NULL |
+-----------+---------+----------+------------+-----------+--------+--------------+
new: 1 row in set (0.00 sec)
old: 1 row in set (11.37 sec)
# faster when specify one region_id

# select * from tikv_region_peers where region_id in (395005,395015,395017);
+-----------+---------+----------+------------+-----------+--------+--------------+
| REGION_ID | PEER_ID | STORE_ID | IS_LEARNER | IS_LEADER | STATUS | DOWN_SECONDS |
+-----------+---------+----------+------------+-----------+--------+--------------+
|    395005 |  410054 |        4 |          0 |         1 | NORMAL |         NULL |
|    395015 |  410061 |        4 |          0 |         1 | NORMAL |         NULL |
|    395017 |  759007 |        1 |          0 |         1 | NORMAL |         NULL |
+-----------+---------+----------+------------+-----------+--------+--------------+
new: 3 rows in set (0.00 sec)
old: 3 rows in set (10.10 sec)
# faster when specify three region_id

# select count(*) from tikv_region_peers where store_id=4;
+----------+
| count(*) |
+----------+
|   182409 |
+----------+
new: 1 row in set (5.45 sec)
old: 1 row in set (10.38 sec)
# faster when specify one store_id

# select count(*) from tikv_region_peers where region_id=395005 and store_id=4;
+----------+
| count(*) |
+----------+
|        1 |
+----------+
new: 1 row in set (4.80 sec)
old: 1 row in set (11.03 sec)
# faster when specify one store_id

# select * from tikv_region_peers where region_id in (395005,395015,395017) and store_id=4;
+-----------+---------+----------+------------+-----------+--------+--------------+
| REGION_ID | PEER_ID | STORE_ID | IS_LEARNER | IS_LEADER | STATUS | DOWN_SECONDS |
+-----------+---------+----------+------------+-----------+--------+--------------+
|    395005 |  410054 |        4 |          0 |         1 | NORMAL |         NULL |
|    395015 |  410061 |        4 |          0 |         1 | NORMAL |         NULL |
+-----------+---------+----------+------------+-----------+--------+--------------+
new: 2 rows in set (4.88 sec)
old: 2 rows in set (10.69 sec)
# faster when specify one store_id

# select * from tikv_region_peers where region_id in (395005,395015,395017) and store_id=0;
Empty set (0.01 sec)
Empty set (10.83 sec)
# faster when specify one store_id

# select count(*) from tikv_region_peers where store_id in (4,7);
+----------+
| count(*) |
+----------+
|   364012 |
+----------+
1 row in set (9.32 sec)
1 row in set (10.30 sec)
# closer when specify two store_id

# select * from tikv_region_peers where region_id in (395005,395015,395017) and store_id in (1,4);
+-----------+---------+----------+------------+-----------+--------+--------------+
| REGION_ID | PEER_ID | STORE_ID | IS_LEARNER | IS_LEADER | STATUS | DOWN_SECONDS |
+-----------+---------+----------+------------+-----------+--------+--------------+
|    395005 |  410054 |        4 |          0 |         1 | NORMAL |         NULL |
|    395015 |  410061 |        4 |          0 |         1 | NORMAL |         NULL |
|    395017 |  759007 |        1 |          0 |         1 | NORMAL |         NULL |
+-----------+---------+----------+------------+-----------+--------+--------------+
new: 3 rows in set (12.90 sec)
old: 3 rows in set (12.03 sec)
# slower when specify two or more store_id

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2022
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2022
@ti-srebot ti-srebot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.4-cherry-pick labels Feb 7, 2022
@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

@nolouch
Copy link
Member

nolouch commented Feb 7, 2022

close it because #31646 fix it.

@nolouch nolouch closed this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/5.4-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants