Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Remove deprecated streaming #32765

Merged
merged 9 commits into from
Mar 10, 2022
Merged

*: Remove deprecated streaming #32765

merged 9 commits into from
Mar 10, 2022

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Mar 3, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #32679

Problem Summary:

Currently we have quite a few deprecated options with no plan to clean them up. This one is not known to confuse/affect users, but I thought I would take a look at the effort required to clean it up, since any simplification of variables helps usability.

It looks relatively straight forward, but we can reassess if feedback reports otherwise.

What is changed and how it works?

Check List

Tests

  • Unit test
    Covered by existing tests, confirming removal is safe.
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility
    Removes functionality from the server which was previously deprecated.

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

The deprecated system variable `tidb-enable-streaming` has been removed.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 3, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@morgo morgo requested a review from a team as a code owner March 3, 2022 01:52
@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 3, 2022
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 3, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Mar 3, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/db4a3b1ae1f6cde9fe1d096f585503a802ed6dbb

@morgo
Copy link
Contributor Author

morgo commented Mar 3, 2022

/run-check_dev_2

@morgo morgo requested review from tiancaiamao and wshwsh12 March 3, 2022 03:11
tiancaiamao
tiancaiamao approved these changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check the document repo in case there is anything related to this feature.

@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 8, 2022

/run-unit-test

@morgo morgo requested a review from bb7133 March 9, 2022 02:40
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2022
bb7133
bb7133 reviewed Mar 10, 2022
View reviewed changes
distsql/distsql.go
if !sctx.GetSessionVars().EnableStreaming {
kvReq.Streaming = false
}
kvReq.Streaming = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like that Streaming field for Request can be removed as well? Anyway even if so, it doesn't have to be done in this PR.

@bb7133 bb7133 added the compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. label Mar 10, 2022
bb7133
bb7133 reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 10, 2022
@bb7133
Copy link
Member

bb7133 commented Mar 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: faa0c8b

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2022
@ti-chi-bot
Copy link
Member

@morgo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 10, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 10, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: db4a3b1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 10, 2022
@morgo
Copy link
Contributor Author

morgo commented Mar 10, 2022

/run-unit-test

@ti-chi-bot ti-chi-bot merged commit 9a4ca3c into pingcap:master Mar 10, 2022
@morgo morgo deleted the remove-streaming branch March 10, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiancaiamao tiancaiamao tiancaiamao approved these changes

@bb7133 bb7133 bb7133 approved these changes

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
compatibility-breaker Violation of forwards/backwards compatibility in a design-time piece. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morgo @ti-chi-bot @sre-bot @bb7133 @tiancaiamao