Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpp: throw an err when mpp generate empty table scan task list (#33084) #33135

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 16, 2022

cherry-pick #33084 to release-5.1
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/33135

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/33135:release-5.1-383f0bb05e7b

What problem does this PR solve?

Issue Number: close #33083

Problem Summary:

What is changed and how it works?

Now mpp cannot handle empty table scan task list.
We temporarily throw an error for this case.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 16, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • guo-shaoge
  • windtalker

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 16, 2022
@ti-srebot ti-srebot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.1-cherry-pick labels Mar 16, 2022
@ti-srebot ti-srebot added this to the v5.1.4 milestone Mar 16, 2022
@ti-srebot
Copy link
Contributor Author

@SeaRise please accept the invitation then you can push to the cherry-pick pull requests. Comment with /cherry-pick-invite if the invitation is expired.
https://github.com/ti-srebot/tidb/invitations

@ti-chi-bot
Copy link
Member

@SeaRise: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 16, 2022
@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@guo-shaoge
Copy link
Collaborator

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a13fb4d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 16, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jun 16, 2022

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

5 similar comments
@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/rebuild

@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

1 similar comment
@SeaRise
Copy link
Contributor

SeaRise commented Jun 16, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 17, 2022

/rebuild

@SeaRise
Copy link
Contributor

SeaRise commented Jun 17, 2022

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 17, 2022

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@hawkingrei
Copy link
Member

/run-mysql-test

3 similar comments
@SeaRise
Copy link
Contributor

SeaRise commented Jun 20, 2022

/run-mysql-test

@hawkingrei
Copy link
Member

/run-mysql-test

@SeaRise
Copy link
Contributor

SeaRise commented Jun 21, 2022

/run-mysql-test

@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2c7c95a into pingcap:release-5.1 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants