-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: support disaggregated tiflash #33535
*: support disaggregated tiflash #33535
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/186a7a8c04f76f2b02522c1994bc554247ac3352 |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
/hold |
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…_mpp_req Signed-off-by: guo-shaoge <shaoge1994@163.com>
Please follow PR Title Format:
Or if the count of mainly changed packages are more than 3, use
After you have format title, you can leave a comment |
…_mpp_req Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…into random_dispatch_mpp_req
logCount++ | ||
s.GetRegionCache().InvalidateTiFlashComputeStores() | ||
if logCount == 60 { | ||
// Print log every 60*duration seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to print the log every 60s? Or you mean 600s?
Signed-off-by: guo-shaoge <shaoge1994@163.com>
…into random_dispatch_mpp_req
/merge |
This pull request has been accepted and is ready to merge. Commit hash: a50994d
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
Signed-off-by: guo-shaoge shaoge1994@163.com
What problem does this PR solve?
Issue Number: close #34707
Problem Summary:
mppTask
totiflash_compute
nodes. (store/copr: fix build batchCop in disaggregated tiflash mode #40008 updates build batchCop)tiflash_compute
store cache fromPD
every 10 seconds. We will use better ways in the near future.What is changed and how it works?
Check List
Tests
1. test-infra E2E case is added: https://github.com/pingcap/endless/pull/657
Side effects
Documentation
disaggregated-tiflash
Release note