gomod: update gomod to fix data race

[hawkingrei]

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: close #32747

Problem Summary:

What is changed and how it works?

• fix data race in the testify
• remove the gomod replacement because this change has been merged into the main branch.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Defined2014
• ngaut

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b126235fa4377f68be803221ce9753d44cc64f4b

[tiancaiamao]

/merge

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 22d9cbf

[tiancaiamao]

I have to point out this may not be the best solution, although it temporarily work for now.
The root cause of the data race is we maybe misuse the testify package.
The Require() method use lazy initialization thus it's not thread-safe.
I guess if we call Require() before the test, most of the DATA RACE can be avoided.

Side-effect after this PR: can't upgrade the testify package later, otherwise we have to fix the data race problem again.

[hawkingrei]

I have to point out this may not be the best solution, although it temporarily work for now. The root cause of the data race is we maybe misuse the testify package. The Require() method use lazy initialization thus it's not thread-safe. I guess if we call Require() before the test, most of the DATA RACE can be avoided.

Side-effect after this PR: can't upgrade the testify package later, otherwise we have to fix the data race problem again.

I agree with you.

• We can wait for merging fix data race in the suit stretchr/testify#1165.
• if this pr is not merged, we can refactor the test to remove suite.Run.

/cc @tisonkun

[tisonkun]

@hawkingrei from the upstream stat I don't think we can get a new release fast. In #26022 I suggest we use testify's assertions only and yes, we can get rid of dependencies of suite, replacing them with go testing subtests.