-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gomod: update gomod to fix data race #33843
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/b126235fa4377f68be803221ce9753d44cc64f4b |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 22d9cbf
|
I have to point out this may not be the best solution, although it temporarily work for now. Side-effect after this PR: can't upgrade the testify package later, otherwise we have to fix the data race problem again. |
I agree with you.
/cc @tisonkun |
@hawkingrei from the upstream stat I don't think we can get a new release fast. In #26022 I suggest we use testify's assertions only and yes, we can get rid of dependencies of |
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What problem does this PR solve?
Issue Number: close #32747
Problem Summary:
What is changed and how it works?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.