Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

table/tables: remove int handle id from row to fix binlog issue (#30489) #34109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Also check the lenght of the row vs number of columns

b1c8468
Select commit
Loading
Failed to load commit list.
Open

table/tables: remove int handle id from row to fix binlog issue (#30489) #34109

Also check the lenght of the row vs number of columns
b1c8468
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Dec 19, 2023 in 1s

55.3047% of diff hit (target 0.0000%)

View this Pull Request on Codecov

55.3047% of diff hit (target 0.0000%)

Annotations

Check warning on line 1106 in br/pkg/lightning/backend/local/local.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/backend/local/local.go#L1106 

Added line #L1106 was not covered by tests

Check warning on line 1250 in br/pkg/lightning/backend/local/local.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/backend/local/local.go#L1250 

Added line #L1250 was not covered by tests

Check warning on line 1295 in br/pkg/lightning/backend/local/local.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/backend/local/local.go#L1294-L1295 

Added lines #L1294 - L1295 were not covered by tests

Check warning on line 158 in br/pkg/lightning/lightning.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/lightning.go#L157-L158 

Added lines #L157 - L158 were not covered by tests

Check warning on line 1115 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1114-L1115 

Added lines #L1114 - L1115 were not covered by tests

Check warning on line 1134 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1133-L1134 

Added lines #L1133 - L1134 were not covered by tests

Check warning on line 1164 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1163-L1164 

Added lines #L1163 - L1164 were not covered by tests

Check warning on line 1187 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1167-L1187 

Added lines #L1167 - L1187 were not covered by tests

Check warning on line 1194 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1193-L1194 

Added lines #L1193 - L1194 were not covered by tests

Check warning on line 1196 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1196 

Added line #L1196 was not covered by tests

Check warning on line 1200 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1198-L1200 

Added lines #L1198 - L1200 were not covered by tests

Check warning on line 1202 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1202 

Added line #L1202 was not covered by tests

Check warning on line 1206 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1206 

Added line #L1206 was not covered by tests

Check warning on line 1208 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1208 

Added line #L1208 was not covered by tests

Check warning on line 1219 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1218-L1219 

Added lines #L1218 - L1219 were not covered by tests

Check warning on line 1505 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1501-L1505 

Added lines #L1501 - L1505 were not covered by tests

Check warning on line 1518 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1517-L1518 

Added lines #L1517 - L1518 were not covered by tests

Check warning on line 1790 in br/pkg/lightning/restore/restore.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

br/pkg/lightning/restore/restore.go#L1790 

Added line #L1790 was not covered by tests

Check warning on line 464 in dumpling/export/config.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

dumpling/export/config.go#L460-L464 

Added lines #L460 - L464 were not covered by tests

Check warning on line 1091 in dumpling/export/dump.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

dumpling/export/dump.go#L1089-L1091 

Added lines #L1089 - L1091 were not covered by tests

Check warning on line 98 in dumpling/export/retry.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

dumpling/export/retry.go#L93-L98 

Added lines #L93 - L98 were not covered by tests

Check warning on line 343 in executor/hash_table.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

executor/hash_table.go#L340-L343 

Added lines #L340 - L343 were not covered by tests

Check warning on line 1543 in planner/core/common_plans.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

planner/core/common_plans.go#L1542-L1543 

Added lines #L1542 - L1543 were not covered by tests

Check warning on line 283 in planner/core/find_best_task.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

planner/core/find_best_task.go#L283 

Added line #L283 was not covered by tests

Check warning on line 302 in planner/core/find_best_task.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

planner/core/find_best_task.go#L294-L302 

Added lines #L294 - L302 were not covered by tests
View more details on Codecov