-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/pessimistictest: fix DATA RACE for tests #34505
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I must reverse the order when reasoning :(
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/9c20932084f5a32a4597ae3ea59c6f532b0b5e6d |
BTW, This problem also shows that this parameter is not designed correctly, there should be an atomic type to avoid. It has been improved in the tikv/client-go#488. |
Further, a dynamic configuration change should not be a normal type of change. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: da989cc
|
TiDB MergeCI notify
|
What problem does this PR solve?
Issue Number: close #34504
Problem Summary:
What is changed and how it works?
Fix data race...
transaction.PrewriteMaxBackoff = 20000
should be afterdom.Close()
,because before
dom.Close()
, the background goroutines are still reading variabletransaction.PrewriteMaxBackoff
Check List
Tests
Verify no DATA RACE after this change:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.