-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools/check: 'ut' now remove support for the old test cases #34800
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although, I'm unsure whether this pr completely "closes" #30822.
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/a32f425b137048d3355689aecf3740173e154e67 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 11025b7
|
/run-mysql-test |
TiDB MergeCI notify🔴 Bad News! [1] CI still failing after this pr merged.
|
What problem does this PR solve?
Issue Number: close #30822
Problem Summary:
Since the test case migration is done #26022, we can now remove the support for the old test case.
What is changed and how it works?
Address comment here #30822 (comment)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.