-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: improve the generation for record the test cases #35369
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/f6b50778aa3a271ab4249ca8b4817cdaa74bc553 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 6ca65a8
|
TiDB MergeCI notify🔴 Bad News! New failing [1] after this pr merged.
|
) close pingcap#35368 address the comment Signed-off-by: yisaer <disxiaofei@163.com> address the comment Signed-off-by: yisaer <disxiaofei@163.com>
What problem does this PR solve?
Issue Number: close #35368
Problem Summary:
Now, if we want to record the test cases result in the planner/core/testdata package, we can use the argument --record when we run the test cases. But it will clear the other test cases' results which have been already recorded. So we should improve the generation for the test cases.
What is changed and how it works?
Check List
Tests
--record
can be worked.Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.